You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Put up barriers to breaking changes. Once we reach v1.0.0, we MUST avoid breaking changes.
Breaking changes include:
Anything that causes the go-apidiff job to fail. (see separate issues related to moving non-API Go code to an internal tree). The APIs will remain exported, so the go-apidiff job will ensure that our Go code defining the APIs is not breaking from a Go perspective.
Anything that would cause Kubernetes clients to experience a breaking change when interacting with instances of our CRD via the Kubernetes apiserver.
The text was updated successfully, but these errors were encountered:
To enshrine goal (1) in our codebase, we could implement a test that enforces a specific set of imports. Any future PR that wants to import a new import path would need to also modify our list of allowed import paths in our API.
I would anticipate that that list would start out as k8s.io/apimachinery.
Goals:
Breaking changes include:
go-apidiff
job to fail. (see separate issues related to moving non-API Go code to an internal tree). The APIs will remain exported, so thego-apidiff
job will ensure that our Go code defining the APIs is not breaking from a Go perspective.The text was updated successfully, but these errors were encountered: