Skip to content

Conversation

@timflannagan
Copy link
Member

Update the contribution guidelines and add a link to the Docsy
documentation instead of the broken [Docsy user guide](wherever it goes)
reference that's currently being deployed.

@openshift-ci openshift-ci bot requested review from anik120 and benluddy June 7, 2021 22:30
@timflannagan
Copy link
Member Author

@hasbro17 Any idea on how to get rid of that Travis CI check? I migrated all of the CI tests to GH actions a couple of months back, so we no longer require a Travis CI configuration for this repository. The last time I talked with the team, it sounded like you had set up Travis for this repository?

Update the contribution guidelines and add a link to the Docsy
documentation instead of the broken `[Docsy user guide](wherever it goes)`
reference that's currently being deployed.
@timflannagan
Copy link
Member Author

I added a second commit that changes the list formatting so the bullet points get properly rendered.

Here is the previous version:

Here is the deploy preview that contains the fixes:

I can move these changes to a separate PR if we have any strong opinions about combining these changes.

@hasbro17
Copy link
Contributor

hasbro17 commented Jun 7, 2021

@timflannagan Sounds like you already got rid .travis.yml when you moved it over to GH actions #103
But I think we had a status check for it in the branch protection rule for master. I've just removed it from there so it should no longer show up anymore.

Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timflannagan timflannagan added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@anik120
Copy link
Member

anik120 commented Jun 9, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit f35180b into operator-framework:master Jun 9, 2021
@timflannagan timflannagan deleted the update-docsy-link branch June 9, 2021 13:56
anik120 pushed a commit to anik120/olm-docs that referenced this pull request Oct 12, 2021
…perator-framework#160)

* content: Add link to the Docsy docs in the contribution guidelines

Update the contribution guidelines and add a link to the Docsy
documentation instead of the broken `[Docsy user guide](wherever it goes)`
reference that's currently being deployed.

* content: Update list styling so bullet points are rendered correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants