possible refinements#3109
possible refinements#3109shawkins wants to merge 0 commit intooperator-framework:reconcile-utils-new-algfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
|
||
| private int activeUpdates = 0; | ||
| private ResourceEvent lastEvent; | ||
| private int lastUpdatedResourceVersion = -1; |
There was a problem hiding this comment.
I don't think we can generally guarentee that the resource versions will fall in the int range.
| int comp = 0; | ||
| if (cached != null) { | ||
| comp = ReconcileUtils.validateAndCompareResourceVersions(resource, cached); | ||
| if (comp >= 0 || unknownState) { |
There was a problem hiding this comment.
@csviri can you explain why this allows for equality?
There was a problem hiding this comment.
Since we can remove the resource in that case from the cache.
There was a problem hiding this comment.
Right, so this needs refined a little further - it should remove, but still be seen as a known event.
There was a problem hiding this comment.
Note that in the implementation we strictly define two cases: when we want to filter the event and when we don't, based on user's intention.
So there is no grey area now.
There was a problem hiding this comment.
The wording may be confusing across a couple of methods.
The boolean used to mean "known event" - so if I put a version into the temporary resource cache, then see the event with the same version, it's a known event.
Does "filter event" have a subtely different meaning from "known event"?
There was a problem hiding this comment.
Hmm good question, the filter event mean to express that the event won't be propagated further (if true). This is bit more descriptive since we might actually not know all the events (watch connection issues).
csviri
force-pushed
the
reconcile-utils-new-alg
branch
from
7b46752 to
be8f5f7
Compare
csviri
force-pushed
the
reconcile-utils-new-alg
branch
from
ef2642a to
df5ade4
Compare
shawkins
force-pushed
the
reconcile-utils-new-alg
branch
from
be8f5f7 to
630cde5
Compare
csviri
force-pushed
the
reconcile-utils-new-alg
branch
from
630cde5 to
be8f5f7
Compare
shawkins
force-pushed
the
reconcile-utils-new-alg
branch
from
df5ade4 to
f414063
Compare
2 participants
A few ideas for simplifying the logic.