Skip to content

Comments

feat: ReconcileUtils for strongly consistent updates#3075

Closed
csviri wants to merge 2 commits intooperator-framework:nextfrom
csviri:reconcile-utils
Closed

feat: ReconcileUtils for strongly consistent updates#3075
csviri wants to merge 2 commits intooperator-framework:nextfrom
csviri:reconcile-utils

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Dec 1, 2025 •
edited
Loading

  • The PR adds utility that provides methods to update resources using comparable resource versions
  • Integrates this utility to the core of the framework (thus simplifying ReconciliationDispatcher)
    • note that this introduces a change in the behavior for the UpdateControl.patchStatus (and others), since it won't trigger the reconiliation for the event in that update.
  • Renames former ReconcilerUtils to ReconcilerUtilsInternal, this is breaking but that utils was never advertised for non-internal usage
  • Includes also fixes for ControllerEventSource event filtering
  • Improves TemporaryResourceCache so it explicitly supports non filtering updates

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2025
@csviri csviri linked an issue Dec 22, 2025 that may be closed by this pull request
Utilities to update and cache resources also for secondary resources with comparable resource version #3011
Closed
@csviri csviri marked this pull request as ready for review December 22, 2025 13:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2025
@openshift-ci openshift-ci bot requested review from metacosm and xstefank December 22, 2025 13:54
csviri
csviri commented Dec 22, 2025
View reviewed changes
...-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ReconcileUtils.java
import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getUID;
import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getVersion;

public class ReconcileUtils {
Copy link
Collaborator Author

@csviri csviri Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As alternative names was thinking about ReconcilerUtils and ReconciliationUtils. What do you think @metacosm @shawkins @xstefank

@csviri csviri requested a review from shawkins December 22, 2025 13:55
@csviri csviri changed the title feat: Reconcile utils feat: ReconcileUtils strongly consistent updates Dec 23, 2025
@csviri csviri changed the title feat: ReconcileUtils strongly consistent updates feat: ReconcileUtils for strongly consistent updates Dec 23, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 25, 2025
@csviri
feat: ReconcileUtils for strongly consistent updates
ef6ff28
@csviri
wip
df023ec 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 25, 2025
@csviri csviri mentioned this pull request Dec 25, 2025
Merged
@csviri
Copy link
Collaborator Author

csviri commented Jan 6, 2026

replaced by: #3106

@csviri csviri closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm Awaiting requested review from metacosm

@xstefank xstefank Awaiting requested review from xstefank

@shawkins shawkins Awaiting requested review from shawkins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Utilities to update and cache resources also for secondary resources with comparable resource version

2 participants

@csviri @openshift-merge-robot