feat: add default stop handler #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have to double check it but stop handler is called now when the informer is stopped explicitly. |
andreaTP
approved these changes
Oct 26, 2022
does this happen? Does JOSDK exposes API to stop watching specific resources? |
No, I think just , on s sig term , when we stop the operators, we do a graceful shutdown. Stop is called, that calls the stop handler. |
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Oct 26, 2022
vmuzikar
approved these changes
Oct 26, 2022
csviri
added a commit
that referenced
this pull request
Oct 28, 2022
csviri
added a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should have here system exit by default.
cc @andreaTP @vmuzikar