Skip to content

feat: allow loading resources as builders #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2022
Merged

feat: allow loading resources as builders #1335

merged 1 commit into from
Jul 14, 2022

Conversation

iocanel
Copy link
Collaborator

@iocanel iocanel commented Jul 13, 2022

Resolves: #1334

loadYaml checks if the target class is a builder and if so, it initalizes the builder using the deserialized yaml.

@csviri
Copy link
Collaborator

csviri commented Jul 13, 2022 •
edited
Loading

@iocanel pls target the new PRs on next branch. We will release that soon (tomorrow). This I will rebase after merged.

csviri
csviri approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit 4e3c62f into operator-framework:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReconcilerUtils.loadYaml should allow loading resources ready to build.
2 participants
@iocanel @csviri