Skip to content

JOSDK v5: Documentation improvements #2624

Closed
@ebma16

Description

@ebma16

Hey,

I'm currently updating in my project josdk to the 5.0.0-beta1. So I am currently reading through the documentation in order to update the registration of the EventSources in my reconcilers.

I have thought about the following topics/suggestions:

  1. I came across the following examples while updating:

From what I can see, the “InformerConfiguration” class does not provide a “from” method anymore (changed with v5). In the example, this should rather be the class “InformerEventSourceConfiguration”, can that be?

  1. The examples in the documentation (such as the one mentioned above) show a simple configuration of an ES using the “InformerEventSourceConfiguration” class and refer to an example in an integration test. Some configurations are now also carried out via the “InformerConfiguration” class (e.g. setting onUpdateFilter), it would perhaps also be helpful to integrate an example of this into the documentation, or to refer to an integration test that contains such a config, such as this one.

  2. The Migration Guide mentions the prepareEventSources method, but does not describe what needs to be adapted there. Perhaps it would be helpful to refer to the documentation for an example.

  3. This link in the Migration Guide is not accessible and should be adjusted.

  4. This example in the documentation is outdated. It should be updated to context. managedWorkflowAndDependentResourceContext(), right?

What do you think about these topics?

Best regards
Martin

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions