Skip to content

Using the CRD name if no finalizer is provided is not a good default #233

Closed
@metacosm

Description

@metacosm

Unfortunately, CRD names don't mandate that their group be a valid domain name, therefore using <plural>.<group>/finalizer is not guaranteed to be a valid finalizer name.
Possible options for the first part of the finalizer identifier:

  • FQN of the associated controller
  • CR Kind + package name
  • CR Kind / CR simple class name + .javaoperatorsdk.io

Tha last one being the less risky in terms of validation, though https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#finalizers doesn't specify that the finalizer id be a valid kubernetes name (which it isn't anyway because of the /) so we probably aren't constrained to only 63 characters length.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions