Change Naming of `reconcilePrecondition` for v5

[csviri]

It can be confusing that in the precondition there is reconcile included, this not really describes the deletion that happens if this condition does not hold.
Maybe it should be just condition ?

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[Javatar81]

When the reconcileCondition holds true first and then later changes to false, the secondary resource is deleted. This is clearly described in the Javadocs. Two questions regarding this:

• Why is it deleted at all? The name would indicate that it is just not reconciled.
• What happens when the reconcileCondition holds false and then changes to true? Is the secondary registered again? This is not stated in the docs.

Maybe instead of renaming the method you could change it is logic. I don't know why it was implemented like that, is there a specific use case this was needed for or is it just an optimization?

[metacosm]

@Javatar81 the idea is that the condition is a barrier for the secondary reconciliation meaning that if the condition is not true then the secondary shouldn't exist and therefore not reconciled (because, if it existed, it certainly should be reconciled to decide whether or not its state is conform to the desired state described by the primary resource). I do agree, though, that this is somewhat confusing.