Skip to content

Unit tests for plugins.go #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2021
Merged

Unit tests for plugins.go #26

merged 1 commit into from
Jul 14, 2021

Conversation

VenkatRamaraju
Copy link
Contributor

Added unit tests for v1alpha/init.go

Note: These tests depend on the v1_suite_test.go test suite file from this PR: #24.

@laxmikantbpandhare
Copy link
Member

Tried locally and working fine.

Running Suite: V1alpha Suite
============================
Random Seed: 1625769467
Will run 5 of 5 specs

•••••
Ran 5 of 5 Specs in 0.000 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 1.10162139s
Test Suite Passed

laxmikantbpandhare
laxmikantbpandhare approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@laxmikantbpandhare laxmikantbpandhare linked an issue Jul 8, 2021 that may be closed by this pull request
Meta-issue: Java Operator #1
Closed
26 tasks
jmrodri
jmrodri approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/quarkus/v1alpha/plugin_test.go
// See the License for the specific language governing permissions and
// limitations under the License.

package v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG we still have the old package name. This should be v1alpha we should probably rename this in a separate PR.

@jmrodri jmrodri merged commit e75bfde into operator-framework:main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

Assignees

@jmrodri jmrodri

@VenkatRamaraju VenkatRamaraju

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta-issue: Java Operator
3 participants
@VenkatRamaraju @laxmikantbpandhare @jmrodri