-
Notifications
You must be signed in to change notification settings - Fork 25
Add makefile to scaffolding #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Just one comments/suggestions. Could you please squash your commits? I usually get these comments on OLM PR's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Just added one comment about the commit Squash.
Since we always squash the PR commits before merging it isn't as big of a deal with the PRs from SDK. For example, the olm_docs repo uses a merge commit when they merge PRs. When using merge commits it is more important to squash commits because it will merge them as is. This is precisely the reason I prefer squash and merge for |
Ah! got it. thank you for clarification. |
No description provided.