Skip to content

Add makefile to scaffolding #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2021
Merged

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented May 17, 2021

No description provided.

@jmrodri jmrodri changed the title Add makefile to scaffolding WIP: Add makefile to scaffolding May 17, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2021
@jmrodri jmrodri changed the title WIP: Add makefile to scaffolding Add makefile to scaffolding May 20, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2021
@jmrodri
Copy link
Member Author

jmrodri commented May 20, 2021

$ make help

Usage:
  make <target>

General
  help             Display this help.

Build
  docker-build     Build docker image with the manager.
  docker-push      Push docker image with the manager.

Deployment
  install          Install CRDs into the K8s cluster specified in ~/.kube/config.
  uninstall        Uninstall CRDs from the K8s cluster specified in ~/.kube/config.
  deploy           Deploy controller to the K8s cluster specified in ~/.kube/config.
  undeploy         Undeploy controller from the K8s cluster specified in ~/.kube/config.

@jmrodri
Copy link
Member Author

jmrodri commented May 20, 2021

$ make deploy
kubectl apply -f target/kubernetes/kubernetes.yml
serviceaccount/java-op-operator created
service/java-op-operator created
rolebinding.rbac.authorization.k8s.io/java-op-operator-view created
deployment.apps/java-op-operator created
$ make install
customresourcedefinition.apiextensions.k8s.io/hellos.zeusville.com created

@jmrodri
Copy link
Member Author

jmrodri commented May 20, 2021

$ make docker-build IMG=quay.io/jesusr/java-operator:latest
mvn package -Dquarkus.container-image.build=true -Dquarkus.container-image.image=quay.io/jesusr/java-operator:latest
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< com.zeusville:java-op >------------------------
[INFO] Building java-op 0.0.1
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ java-op ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ java-op ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ java-op ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/devel/jesusr/dev/java-op/src/test/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ java-op ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ java-op ---
[INFO] No tests to run.
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ java-op ---
[INFO] 
[INFO] --- quarkus-maven-plugin:1.12.2.Final:build (default) @ java-op ---
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.469 s
[INFO] Finished at: 2021-05-20T13:37:17-04:00
[INFO] ------------------------------------------------------------------------

@laxmikantbpandhare
Copy link
Member

laxmikantbpandhare commented May 24, 2021

Just one comments/suggestions.

Could you please squash your commits? I usually get these comments on OLM PR's.

Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Just added one comment about the commit Squash.

@jmrodri jmrodri merged commit 26d04f1 into operator-framework:main May 24, 2021
@jmrodri
Copy link
Member Author

jmrodri commented May 24, 2021

Just one comments/suggestions.

Could you please squash your commits? I usually get these comments on OLM PR's.

Since we always squash the PR commits before merging it isn't as big of a deal with the PRs from SDK. For example, the olm_docs repo uses a merge commit when they merge PRs. When using merge commits it is more important to squash commits because it will merge them as is. This is precisely the reason I prefer squash and merge for main or master it keeps the history looking nice and it allows you to use as many commits as you want in the PR.

@laxmikantbpandhare
Copy link
Member

Ah! got it. thank you for clarification.

@jmrodri jmrodri deleted the add-makefile branch May 25, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants