Skip to content

Conversation

@joelanford
Copy link
Member

Fixes #316

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the rest-config-mapping branch from 5a43aa9 to 5a44fe1 Compare April 11, 2024 13:51
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.69%. Comparing base (08ab7fb) to head (5a44fe1).
Report is 13 commits behind head on main.

Files Patch % Lines
pkg/client/actionconfig.go 74.35% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   85.06%   85.69%   +0.62%     
==========================================
  Files          19       19              
  Lines        1346     1510     +164     
==========================================
+ Hits         1145     1294     +149     
- Misses        125      139      +14     
- Partials       76       77       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@porridge
Copy link
Member

FTR, I cherry-picked this change to what stackrox operator uses and ran our e2e tests in a loop to see if this would provoke increased memory usage like it did before #198 but found no adverse effects.

With this change:

ocp
gke

Without this change:

ocp-baseline
gke-baseline

@joelanford joelanford marked this pull request as ready for review April 23, 2024 12:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one question.

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@joelanford joelanford added this pull request to the merge queue Apr 23, 2024
Merged via the queue into operator-framework:main with commit 6e98159 Apr 23, 2024
@joelanford joelanford deleted the rest-config-mapping branch April 23, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deps area/sdk area/testing lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to use a different *rest.Config based on the content of the reconciled object

4 participants