Skip to content

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Dec 3, 2021

Description

The Validators are static checks (linters) that can scan the manifests and provide
with low-cost valuable results to ensure the quality of the distributions which will be distributed via OLM,
as to ensure that they are respecting some specific criteria for vendors and/or catalogs.

This proposal aims to provide a standard definition to reduce the complexities of keeping these rules
maintained and consumed.

The goal of this proposal is to ensure that we can along with a defined standard concept and vision
which can help us in the medium/long term have solutions with better maintainability, usability and understandability
levering in what we have implemented currently.

Copy link
Contributor

@fgiloux fgiloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may be me missing some background but after reading the enhancement proposal I am not sure what you will technically deliver when it is implemented. I am not sure what the ABIs are you want to standardize on

Co-authored-by: Brett Tofel <btofel@redhat.com>
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Dec 3, 2021

Hi @fgiloux,

About : #105 (review)

As we spoke:

That is implemented already. See that we are moving some checks from operator-framowork/API. The standard/idea can be applied outside but that is more for us. The main goal is to clarify why we are moving them out, what is the idea/suggestion to work with the validators ( examples section ) and why/how.

Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. If you can just add the context of these being bundle validators. (i.e. the manifests from bundle images etc.)

@camilamacedo86
Copy link
Contributor Author

Closing since it seems that the info here did not fit well in the EP.
But we tried to address the usage in : operator-framework/api#205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants