-
Notifications
You must be signed in to change notification settings - Fork 38
Standard definition for the Validators (linters) #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard definition for the Validators (linters) #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That may be me missing some background but after reading the enhancement proposal I am not sure what you will technically deliver when it is implemented. I am not sure what the ABIs are you want to standardize on
Co-authored-by: Brett Tofel <btofel@redhat.com>
Hi @fgiloux, About : #105 (review) As we spoke: That is implemented already. See that we are moving some checks from operator-framowork/API. The standard/idea can be applied outside but that is more for us. The main goal is to clarify why we are moving them out, what is the idea/suggestion to work with the validators ( examples section ) and why/how. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. If you can just add the context of these being bundle validators. (i.e. the manifests from bundle images etc.)
Closing since it seems that the info here did not fit well in the EP. |
Description
The Validators are static checks (linters) that can scan the manifests and provide
with low-cost valuable results to ensure the quality of the distributions which will be distributed via OLM,
as to ensure that they are respecting some specific criteria for vendors and/or catalogs.
This proposal aims to provide a standard definition to reduce the complexities of keeping these rules
maintained and consumed.
The goal of this proposal is to ensure that we can along with a defined standard concept and vision
which can help us in the medium/long term have solutions with better maintainability, usability and understandability
levering in what we have implemented currently.