-
Couldn't load subscription status.
- Fork 22
[WIP] deppy catsrc adapter #71
Conversation
|
|
||
| message Entity { | ||
| EntityID id = 1; | ||
| map<string,string> properties = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I know this is not in the design doc, so this is a design quesiton, not an impl question)...
Do we need a separate constraints field here?
- Properties that are not understood can likely be ignored by deppy
- Constraints that are not understood should probably result in a resolution error (or at least there should be a knob that lets the user decide whether unknown constraints should be failures)
Without a separate constraints field, it seems like deppy will need to have knowledge about how to extract constraints from properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constraints should be something that the layer above the adapter understands, it didn't seem appropriate to assume constraints directly from the catalogsource.
| @@ -0,0 +1,24 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there discussion about what protocol to use for the deppy source API? I'm curious if we revisited tradeoffs of GRPC vs vanilla HTTP/JSON vs something else, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into OpenAPI as an alternative for an HTTP/JSON endpoint, but it didn't make the building out of the API any easier or its definition simpler. There are other options, but GRPC seemed more straightforward for an initial API.
436609a to
0a10f57
Compare
34ec7cd to
798b82a
Compare
798b82a to
1dff4e9
Compare
1dff4e9 to
6f53853
Compare
6f53853 to
3862cab
Compare
3862cab to
68a64cc
Compare
|
@ankitathomas: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the |
|
This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the |
|
Closing in favor of operator-framework/operator-controller#129 |
Implementation of a deppy source adapter that can provide a ListEntities functionality.
This prototype uses a single CatalogSource specified either by its namespaced name or its serving address as a data source. This model necessitates the addition of another controller layer on top of the adapter to create and monitor adapters for all catalogsources and lacks any caching at the adapter side, which may be performance concerns. Some of these issues may be solvable by a cluster-scoped unified data source.
See https://github.com/anik120/rukpak-packageserver