Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove DeppySolver wrapper and export internal solver instead #165

Merged
merged 2 commits into from
Dec 4, 2023
Merged

⚠️ Remove DeppySolver wrapper and export internal solver instead #165

merged 2 commits into from
Dec 4, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Dec 1, 2023 •
edited
Loading

Closes #161

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e676cce) 63.90% compared to head (4dfd241) 63.36%.
Report is 1 commits behind head on main.

❗ Current head 4dfd241 differs from pull request most recent head eae1c32. Consider uploading reports for the commit eae1c32 to get more accurate results

Files Patch % Lines
cmd/dimacs/cmd.go 0.00% 9 Missing ⚠️
pkg/deppy/solver/solve.go 89.28% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   63.90%   63.36%   -0.54%     
==========================================
  Files          11       10       -1     
  Lines         482      464      -18     
==========================================
- Hits          308      294      -14     
+ Misses        155      154       -1     
+ Partials       19       16       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncdc
Copy link
Member

ncdc commented Dec 4, 2023

LGTM once you rebase!

@m1kola
Remove DeppySolver wrapper
fc57b6f 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
Export internal solver
eae1c32 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola marked this pull request as ready for review December 4, 2023 15:17
@m1kola m1kola requested a review from a team as a code owner December 4, 2023 15:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2023
@m1kola
Copy link
Member Author

m1kola commented Dec 4, 2023

@ncdc rebased. Please take another look.

@ncdc ncdc added this pull request to the merge queue Dec 4, 2023
Merged via the queue into operator-framework:main with commit 75c37b5 Dec 4, 2023
5 checks passed
@m1kola m1kola changed the title Remove DeppySolver wrapper and export internal solver instead ⚠️ Remove DeppySolver wrapper and export internal solver instead Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change: remove DeppySolver wrapper and export internal solver
2 participants
@m1kola @ncdc