This repository was archived by the owner on Mar 3, 2025. It is now read-only.
🐛 Set recommended leaderelection settings #519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensive e2e tests revealed that catalogd might run into leader election timeouts during cluster bootstrap, causing sporadic alerts being generated. This commit uses recommended settings for leaderelection LeaseDuration: 15s -> 137s RenewDeadline: 10s -> 107s RetryPeriod: 2s -> 26s Warning: This will increase potential down-time of catalogd to 163s in the worst case (up from 17s). (LeaseDuration + RetryPeriod)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 37.20% 37.02% -0.18%
==========================================
Files 15 15
Lines 1258 1264 +6
==========================================
Hits 468 468
- Misses 740 746 +6
Partials 50 50 ☔ View full report in Codecov by Sentry. |
4 tasks
|
Hi @thetechnick, We are no longer doing changes in this repo. It is deprecated, see the readme: https://github.com/operator-framework/catalogd For upstream, these changes need to be done at: https://github.com/operator-framework/operator-controller/blob/main/catalogd/cmd/catalogd/main.go at the same PR that we have already: operator-framework/operator-controller#1663 For downstream:
|
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensive e2e tests revealed that catalogd might run into leader election timeouts during cluster bootstrap, causing sporadic alerts being generated.
This commit uses recommended settings for leaderelection:
Warning:
This will increase potential down-time of catalogd to 163s in the worst case (up from 17s). (LeaseDuration + RetryPeriod)