bugfix: make spec.grpcPodConfig.priorityClassName a *string #204
Conversation
|
/assign @estroz |
|
/lgtm |
perdasilva
force-pushed
the
grpc_config_fix
branch
from
deabb62 to
77bc18d
Compare
|
What's the difference between Overall I think this is fine because most consumers define their CatalogSource's via yaml configs, so this doesn't affect most people. |
|
if they leave it unset it, nothing will happen. If they set it to "", then we'll set it to "" in the pod, basically. I'll fix the protobuf tags!! |
perdasilva
force-pushed
the
grpc_config_fix
branch
from
77bc18d to
d40521d
Compare
Signed-off-by: Per G. da Silva <perdasilva@redhat.com>
perdasilva
force-pushed
the
grpc_config_fix
branch
from
d40521d to
05f1dcc
Compare
|
Sounds good. Lets see if I can get prow to override go-apidiff /override Go/go-apidiff |
|
@estroz: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override tide |
|
@estroz: Overrode contexts on behalf of estroz: tide In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override go-apidiff |
|
@estroz: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Merging by hand |
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "time" |
There was a problem hiding this comment.
Interesting - I'm surprised the format check didn't complain about this but I guess gofmt might no care about import ordering/chunking/etc.?
There was a problem hiding this comment.
It doesn't have an opinion about std vs. external module chunking, just sorts within chunks. goimports does care i think.
Description
This PR updates the CatalogSource spec.grpcPodConfig.priorityClassName to be a *string. The main motivation being that empty string has meaning for this attribute so we need to distinguish whether it was set by the user or not.