Add Timestamp to Scorecard Test Results #137
Conversation
Signed-off-by: Ish Shah <ishah@redhat.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
There was a problem hiding this comment.
Is there some context for the addition of this field that explains what it will be used for?
A few questions in the meantime:
- What is this the timestamp of? When the test was launched, when it completed, something else?
- Depending on the answer to 1), I'm wondering if it makes more sense to be in the
TestStatusorTestResultstruct?
| // Test specifies a single test run. | ||
| type Test struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| Tstamp string `json:"tstamp,omitempty"` |
There was a problem hiding this comment.
Is it possible to use metav1.Time instead of a string?
There was a problem hiding this comment.
We can use a time object and convert to a string later when it's needed. I wanted to add this field because Xunit output's would like a timestamp on the test result.
- Current plan is to time stamp upon the creation of the result
- Seems reasonable to move it to the result struct instead
Signed-off-by: Ish Shah <ishah@redhat.com>
|
Updated to move timestamp to the result struct and changed type to metav1.Time. |
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, theishshah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
Add field for time stamp in scorecard results