Add validation to CSV name length #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given CSV's name is used as label for OLM, its length should be validated to ensure it's not over the label character limit which is currently set at 63 character. This commit will enable CSV validation returning an error if CSV's name is more than 63 characters. Signed-off-by: Vu Dinh <vudinh@outlook.com>
openshift-ci
bot
added
the
approved
estroz
reviewed
Jun 23, 2021
dinhxuanvu
force-pushed
the
csv-name-limit
branch
from
69ef7ba to
c94fee5
Compare
estroz
reviewed
Jun 23, 2021
dinhxuanvu
force-pushed
the
csv-name-limit
branch
from
c94fee5 to
bf51053
Compare
estroz
reviewed
Jun 23, 2021
dinhxuanvu
force-pushed
the
csv-name-limit
branch
from
bf51053 to
64646a7
Compare
The unit test is targeted with CSV with name that is over 63 characters limit. Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
csv-name-limit
branch
from
64646a7 to
1a28166
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given CSV's name is used as label for OLM, its length should be
validated to ensure it's not over the label character limit
which is currently set at 63 character.
This commit will enable CSV validation returning an error if CSV's
name is more than 63 characters.
Signed-off-by: Vu Dinh vudinh@outlook.com