updating dependencies to support k8s 1.32 #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acornett21
added
the
do-not-merge/work-in-progress
acornett21
force-pushed
the
k8s_1_32
branch
2 times, most recently
from
b57398e to
00494e8
Compare
acornett21
removed
the
do-not-merge/work-in-progress
acornett21
force-pushed
the
k8s_1_32
branch
2 times, most recently
from
6ae74b4 to
5788e4e
Compare
Signed-off-by: Adam D. Cornett <adc@redhat.com>
| # index: 1 | ||
| # create: true | ||
| # | ||
| # - source: # Uncomment the following block if you have a ValidatingWebhook (--programmatic-validation) |
There was a problem hiding this comment.
All this code must be removed from the scaffold
Sorry it passed in my review :-(
We need to use the plugins.Replace to replace the whole const from here.
There was a problem hiding this comment.
See the change for helm: https://github.com/operator-framework/operator-sdk/pull/6928/files
We probably ( should have a func already, we just need to update the const like here: https://github.com/operator-framework/operator-sdk/blob/4407fd6723aef2063d1dde356abf59ca3bbc849f/internal/plugins/util/cleanup.go#L62
There was a problem hiding this comment.
Also, we need to remove the new things for Prometheus and Metrics with certmanager: operator-framework/operator-sdk@713b76c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Updating dependencies to support k8s 1.32.
Motivation for the change:
To stay current with k8s support.