Run Engine.SetAvailable() on all engines #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetAvailable() was invoked only for the docker engine, since it is the only engine that actually hooks its fetching logic there. The side-effect was that a new engine would not have an entry point for fetching a bundle.
|
@ctrochalakis Could you sign the CLA (available from the above details link) so we can merge your PR? |
|
Hello @kevsmith, I think it should be ok now. |
|
Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetAvailable() was invoked only for the docker engine, since it is the
only engine that actually hooks its fetching logic there.
The side-effect was that a new engine would not have an entry point for
fetching a bundle.