Remove the "Create <resource>" line

[lhaskins]

In cogctl, we state the we have created a specific resource and then supply the ID and other information concerning the created resource.

It's redundant to display this message. We can remove the "Created " line from the output displayed.

[vanstee]

In some commands we use those lines to display actions that happened during the command for instance that aren't necessarily clear. Running cogctl relays create test-relay --enable --relay-groups=default-group prints something like the following before returning.

Created test-relay
Enabled test-relay
Added test-relay to default-group

Do we want to explain those actions anywhere? I kinda considered the details as the extra content for these commands rather than the actions themselves. If the variable number of action lines are causing issues for parsing I'd recommend that we don't include the detail view and tell users to always run the cogctl relays info style command after cogctl relays create exited successfully.

[lhaskins]

My thinking is that the results of such a command would be more along the lines of

ID             12345678
Name           test-relay
Status         enabled
Relay Groups   default-group

If the enable flag or relay-groups list is not included, then that information doesn't get displayed - only the Name and ID.

This way the user can still see the results of the command without the additional command execution.

[vanstee]

Cool. I think that'll work.

[lhaskins]

Motivation/Objective

The additional line of "Created " is redundant. We should just should the result of the creation given the information used to create it.

Research

There are a few commands (chat handles, rules) that have not been converting over to using the "new" CogApi" endpoints. These should be converted over, if possible. (Don't want to jump the gun, if work has not been completed. Completion of that work should be in a separate PR that may or may not be apart of this issue.)

There are also some commands that currently only display that a task has been completed. It is more useful to display the ID and Name of what is being completed. For example, as stated in previous comments in this issue, given the command cogctl relays create test-relay --enable --relay-groups=my-group,default-group the result should be

ID             12345678
Name           test-relay
Status         enabled
Relay Groups   default-group, my-group

It should be noted, as stated above, if the enable flag or relay-groups flag (actual flag is groups) is not present, the corresponding information would not be included. The groups listed will be sorted in alphabetical order. Extra information will be displayed when a flag is set. Flag defaults should be set to false.

The relay-group, role, and permission create commands will follow suite.

Plan

We are moving away from stating things such as Created relay-group test-relay and instead upon creation, we display the information set during the creation process.

Issue #580 will address moving the rendering logic to simplify any changes to the output displayed from command execution.

Note:There are many instances where we have statements that a particular task has been performed. This issue is limited to the create action of those different resources..

Tasks

• Bundles
• Chat Handles
• Groups
• Permissions
• Roles
• Rules
• Triggers
• Users
• Update/add tests.
• Update/add documentation.

[mpeck]

This sounds reasonable to me, but I'm wondering if we should break it up a bit more. I think it might be useful to do one resource at a time. That should keep the PRs relatively small and help review move more quickly. It also means that we can break things up between multiple people if need be, and not worry about getting in each others way.

I'm not 100% sure what the best way to note that here would be though. Maybe a list of resources as tasks and then include the list you have here for each resource PR, just to help make sure that we don't miss anything.