#158: Fixed .Net 4.6.1 support for the ASP.Net Core midddleware

[adamrodger]

This allows the ASP.Net Core middleware to be restored in .Net 4.6.1 using the 1.x CLI tools, whereas the previous code only allowed restore via the 2.x CLI tools.

[adamrodger]

The Travis CI failure is a compilation error because the 4.6.1 targeting pack isn't installed on the CI job, which isn't something I can fix. It compiles locally though.

[fedj]

Hi @adamrodger,

Thanks for this PR. I need to take a look at travis but without having it compile, I won't be able to merge your PR. Let me check and get back to you asap

[adamrodger]

They have a guide on how to build using .Net Core here: https://docs.travis-ci.com/user/languages/csharp/#.NET-Core

I'd unpick the dependencies myself but that would turn this into a really big MR. Ideally the project needs one root solution file which contains all of the projects, and then the build can be as simple as:

dotnet restore
dotnet build
dotnet test path/to/test/project.csproj

That would remove the needs for FAKE altogether.

[fedj]

I think you're right. I'll try to come up with a draft PR today

[fedj]

@adamrodger Your PR will be possible when we'll merge #160

[fedj]

@adamrodger you can now rebase your PR and it should compile

[adamrodger]

Thanks, will do it today

…

On Tue, 14 Nov 2017, 10:37 Jeanneret Pierre-Hugues, < ***@***.***> wrote: @adamrodger <https://github.com/adamrodger> you can now rebase your PR and it should compile — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#159 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfCqhoVF8Vd1kumbNjIDubZqvCdKIdJks5s2W2AgaJpZM4QZeLH> .

[adamrodger]

OK, looks like that's passing on Travis CI now. Thanks!

[fedj]

Thanks a lot for the PR @adamrodger !

[adamrodger]

No problems. If you could release a v1.1.1 NuGet package with the change in, that'd be great.

[fedj]

I'm working on appveyor to publish it almost automatically. Can it wait tomorrow in order to test the script ? If not, that's no problem and I can provide you with a nuget asap

[adamrodger]

Yeah no problems

…

On Tue, 14 Nov 2017, 16:27 Jeanneret Pierre-Hugues, < ***@***.***> wrote: I'm working on appveyor to publish it almost automatically. Can it wait tomorrow in order to test the script ? If not, that's no problem and I can provide you with a nuget asap — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#159 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfCqjcgBoQJsNMei9Ek1j5y6PShubhnks5s2b9ogaJpZM4QZeLH> .

[fedj]

Hi @adamrodger,

Thank you for your patience. The nuget is available as 1.1.1 and was automatically published.

[adamrodger]

Thanks very much! I'll upgrade now

…

On Wed, 15 Nov 2017, 09:57 Jeanneret Pierre-Hugues, < ***@***.***> wrote: Hi @adamrodger <https://github.com/adamrodger>, Thank you for your patience. The nuget is available as 1.1.1 and was automatically published. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#159 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfCqgaB6beafAuSVOTg0zWbqhMkdTNEks5s2rV2gaJpZM4QZeLH> .