Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ZipkinHttpTraceInjector compliant with B3 specification #105

Closed
crntn opened this issue Aug 1, 2017 · 0 comments
Closed

Make ZipkinHttpTraceInjector compliant with B3 specification #105

crntn opened this issue Aug 1, 2017 · 0 comments

Comments

@crntn
Copy link
Collaborator

crntn commented Aug 1, 2017

Currently ZipkinHttpTraceInjector serializes ids as upper-hex but according to http://zipkin.io/pages/instrumenting.html they should be lower-hex.

this could lead to compatibility issues.
@crntn crntn changed the title Make ZipkinHttpTraceInjector compilant with B3 specification Make ZipkinHttpTraceInjector compliant with B3 specification Aug 1, 2017
fedj pushed a commit that referenced this issue Aug 2, 2017
Trace propagation should be lowercase.
ea550dd 
Fixes #105
@fedj fedj mentioned this issue Aug 2, 2017
Merged
fedj pushed a commit that referenced this issue Aug 2, 2017
Trace propagation should be lowercase.
87f5c07 
Fixes #105
fedj pushed a commit that referenced this issue Aug 3, 2017
Trace propagation should be lowercase.
dbd27ac 
Fixes #105
@fedj fedj closed this as completed in #111 Aug 3, 2017
fedj pushed a commit that referenced this issue Aug 3, 2017
@fedj
Trace propagation should be lowercase.
2990abc 
Fixes #105
fedj added a commit that referenced this issue Jan 16, 2019
@fedj
Trace propagation should be lowercase.
367cea9 
Fixes #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crntn