Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds b3:0 header to avoid trace amplification when using proxies #180

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Adds b3:0 header to avoid trace amplification when using proxies #180

merged 1 commit into from
Sep 10, 2020

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt merged commit 4dc4b69 into master Sep 10, 2020
@codefromthecrypt codefromthecrypt deleted the love-bas branch September 10, 2020 23:53
shakuzen
shakuzen reviewed Sep 11, 2020
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anuraaga
anuraaga reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, shouldn't we set x-b3 too? Aren't there proxies that don't support b3 and would have write amplification? Or does proxy == envoy now adays (I'd buy it :P)

@codefromthecrypt
Copy link
Member Author

good question: more bytes on the wire, and would prefer to let such an old proxy that doesn't know "b3" yet, and needs this, become known! I'd prefer to convince them to support "b3" rather than force another and longer header on everyone.

@codefromthecrypt
Copy link
Member Author

openzipkin/b3-propagation#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen left review comments

@anuraaga anuraaga anuraaga left review comments

@jcchavezs jcchavezs Awaiting requested review from jcchavezs

@basvanbeek basvanbeek Awaiting requested review from basvanbeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codefromthecrypt @anuraaga @shakuzen