-
Notifications
You must be signed in to change notification settings - Fork 60
Open
Description
isShared and usesTraceId128bits are being provided in the wrong positional order, which causes them to be set incorrectly.
zipkin-php/src/Zipkin/Propagation/TraceContext.php
Lines 200 to 211 in bad09ac
| public function withSampled(bool $isSampled): SamplingFlags | |
| { | |
| return new TraceContext( | |
| $this->traceId, | |
| $this->spanId, | |
| $this->parentId, | |
| $isSampled, | |
| false, | |
| $this->usesTraceId128bits, | |
| $this->isShared, | |
| $this->extra | |
| ); |
zipkin-php/src/Zipkin/Propagation/TraceContext.php
Lines 33 to 51 in bad09ac
| private function __construct( | |
| string $traceId, | |
| string $spanId, | |
| ?string $parentId, | |
| ?bool $isSampled, | |
| bool $isDebug, | |
| bool $isShared, | |
| bool $usesTraceId128bits, | |
| array $extra | |
| ) { | |
| $this->traceId = $traceId; | |
| $this->spanId = $spanId; | |
| $this->parentId = $parentId; | |
| $this->isSampled = $isDebug ?: $isSampled; | |
| $this->isDebug = $isDebug; | |
| $this->isShared = $isShared; | |
| $this->usesTraceId128bits = $usesTraceId128bits; | |
| $this->extra = $extra; | |
| } |
Metadata
Metadata
Assignees
Labels
No labels