Make paths more generic

[satyamtg]

This makes the fix_ogvjs_dist.py more generic by adding functionality as mentioned in issue #1 .
@rgaudin @kelson42 please suggest changes/improvements.

Fixes #1

[rgaudin]

Thanks. Please fix the codefactor and ask for a request when you're ready

[satyamtg]

Hey @rgaudin , have fixed it. Should work now. Please have a look.

[rgaudin]

thanks for your PR but unfortunately it's not acceptable:

• it's not working! str.replace() does not replace in place.
• you did not respect the code formatting (black). I'm not sure why the tests didn't run on github but should they have they would have told you that. Should you have launched the tests locally, you would have know also.
• don't exit on error with a useless message. Raise with an informative message and let it crash.
• gen_extra_jumps() is too verbose for what it does. should be simplified.
• in get_directory_count_and_string() use already imported pathlib and .parts instead of your comprehension loop
• in same function, the map is absolutely useless. What is even the point of that directory_string variable?

Please, don't submit PR for code that you haven't run and tested. I've probably spent more time reviewing your PR than you did to write it… and the issue is not fixed yet. That's counter-productive.

Also, when submitting a PR, use the Request feature to request a review. That way we get a notification and know you're done working on your PR.

[satyamtg]

Did a quick fix and ran all tests. I am not going to propose even a single line of untested code. It works now and I've tried to keep the code as short as possible. Also, I did wanted to Request for review previously but I cannot assign any reviewer (GitHub won't let me for this repo). I can only re-request.

[rgaudin]

Great work, thanks for fixing it all 👍