Skip to content

Creator.add_item_for content param hint #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

Creator.add_item_for content param hint #108

merged 1 commit into from
Jul 18, 2023

Conversation

@AmirAflak
Copy link
Contributor

@AmirAflak AmirAflak commented Jul 18, 2023 •
edited by kelson42
Loading

content param to accept string param hint.

Fixes #107

@rgaudin rgaudin self-requested a review July 18, 2023 12:19
rgaudin
rgaudin approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@rgaudin rgaudin changed the title fix: #107 to handle string type Creator.add_item_for content param hint Jul 18, 2023
@rgaudin rgaudin merged commit 7453f06 into openzim:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creator.add_item_for content param hint is incorrect

2 participants

@AmirAflak @rgaudin