Adding imaging.py and updating requirements for Nautilus compatibility #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgaudin I have tried to assign this PR to the issue in Nautilus, but I was unable to do that. |
|
No you didn't understand. We don't want to copy a file from an old version of the library. I told you scraperlib's API changed but the feature are certainly still in scraperlib, at a different location. You just need to adapt the imports and the calls |
|
And that would be in nautilus, not here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rgaudin I have added the required imaging.py file and updated requirements to support the pillow library which is used in imaging.py .
This will give nautilus the required functionality and allows nautilus to use scraperlib version 3.0.0 instead of the 1.1.1 version it is using.