Bind Archive.get_random_entry() method#220
Merged
rgaudin merged 3 commits intoopenzim:mainfrom Mar 26, 2025
Merged
Conversation
Member
|
Thank you @TheEvilSkeleton ; can you add simple unit test(s) for this? |
TheEvilSkeleton
force-pushed
the
get-random
branch
from
d273941 to
dd19487
Compare
TheEvilSkeleton
force-pushed
the
get-random
branch
from
dd19487 to
4b1f18a
Compare
Contributor
Author
|
@rgaudin can you test if the test works? Running pytest locally doesn't seem to work |
rgaudin
approved these changes
Mar 26, 2025
Member
rgaudin
left a comment
rgaudin
left a comment
There was a problem hiding this comment.
Thank you ; tested locally, it works fine.
I've improved the test slightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.