Don't mirror 'Story' namespace #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
namespace-blacklist
branch
from
918fae7
to
d2768ef
Compare
|
@VadimKovalenkoSNF I have the feeling the failing test has nothing to do with this PR. Do you confirm? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
=======================================
Coverage 74.73% 74.74%
=======================================
Files 33 33
Lines 2810 2811 +1
Branches 626 626
=======================================
+ Hits 2100 2101 +1
Misses 613 613
Partials 97 97
☔ View full report in Codecov by Sentry. |
|
@VadimKovalenkoSNF seems to work now !?! |
|
@kelson42 Yes, but I suspect that something is wrong with the pipeline. I got similar test issues that appeared today in other PRs. |
|
I made a few changes and added tests for the blacklisted namespace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the concept of namespace blacklist for this.
Fixes #1853