Update error handling for downloading files from AWS

src/S3.ts

@@ -1,6 +1,7 @@
 import { S3Client, PutObjectCommand, GetObjectCommand, DeleteObjectCommand, HeadBucketCommand } from '@aws-sdk/client-s3'
 import * as logger from './Logger.js'
 import { Readable } from 'stream'
+import { publicIpv4 } from 'public-ip'
 
 interface BucketParams {
   Bucket: string
@@ -46,8 +47,13 @@ class S3 {
 
     return this.bucketExists(this.bucketName)
       .then(() => true)
-      .catch((err) => {
-        throw new Error(`Unable to connect to S3: ${err.message}`)
+      .catch(async () => {
+        throw new Error(`
+        Unable to connect to S3, either S3 login credentials are wrong or bucket cannot be found
+                            Bucket used: ${this.bucketName}
+                            End point used: ${s3UrlBase.href}
+                            Public IP used: ${await publicIpv4()}
+        `)
       })
   }
 
@@ -97,10 +103,12 @@ class S3 {
           } else reject()
         })
         .catch((err: any) => {
-          logger.log('S3 error while downloading file', err)
-          if (err && err.statusCode === 404) {
+          // For 404 error handle AWS service-specific exception
+          if (err && err.name === 'NoSuchKey') {
+            logger.log(`Error: The specified key ${key} does not exist.`)
             resolve(null)
           } else {
+            logger.log(`Error while downloading the file ${err}`)
             reject(err)
           }
         })

test/unit/s3.test.ts

@@ -38,7 +38,8 @@ describeIf('S3', () => {
     // Remove Image after test
     await s3.deleteBlob({ Bucket: s3UrlObj.query.bucketName as string, Key: s3TestKey })
 
+    const imageNotExist = await s3.downloadBlob('bm.wikipedia.org/static/images/project-logos/polsjsshsgd.png')
     // Image doesnt exist in S3
-    await expect(s3.downloadBlob('bm.wikipedia.org/static/images/project-logos/polsjsshsgd.png')).rejects.toThrow()
+    expect(imageNotExist).toBeNull()
   })
 })