-
-
Notifications
You must be signed in to change notification settings - Fork 1
Enhance image processing and more #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 46.49% 45.22% -1.27%
==========================================
Files 12 13 +1
Lines 727 849 +122
Branches 94 111 +17
==========================================
+ Hits 338 384 +46
- Misses 376 452 +76
Partials 13 13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #61
Fix #27
Changes:
Test ZIM (1% of geo.libretexts.org mentioned in #61) goes down to 107M instead of 207M, and execution time is somewhere between 3 mins (when everything is in S3 cache) up to 7 mins (when everything needs to be downloaded, opimized and uploaded to cache).
I chose joblib for parallel job execution because: