Some fixes about window compilation #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
approved these changes
Aug 14, 2024
As specified in https://en.cppreference.com/w/cpp/string/byte/isspace we must cast char to `unsigned char` before using isspace. Else behaviour is undefined and it is an assert on Windows.
For some unknown reason, xapian compiled on Windows/meson crash when we use this flag. Let's allow us to deactivate this flag until we fix the root bug.
mgautierfr
force-pushed
the
windows_fixes
branch
from
d359f55
to
bc65f30
Compare
|
Commits was created on a remote Windows machine with different keyboard layout. A lot of typos was made. This is fixed now. I'm merging. |
|
@mgautierfr Please open an issue so we don't forget that there is something to fix on windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly a following of kiwix/kiwix-build#715 but it is autonomous.
The flag
Compactor::FULLERwill be readd on Windows once xapian compilation on Windows using meson will be fixed.