-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows CI with GitHub actions #894
Merged
Merged
Commits on Jun 7, 2024
-
Correctly set LIBZIM_EXPORT_DLL
`static_linkage` is about how we link with dependency libraries. We must set `LIBZIM_EXPORT_DLL` depending of how we build libzim library.
Configuration menu - View commit details
-
Copy full SHA for 913abe5 - Browse repository at this point
Copy the full SHA 913abe5View commit details
Commits on Jun 14, 2024
-
Make internal classes LIBZIM_PRIVATE_API.
While they are internal (and not part of public API), unittest are testing them and so we need to link to them.
Configuration menu - View commit details
-
Copy full SHA for c8f2c67 - Browse repository at this point
Copy the full SHA c8f2c67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3588aa8 - Browse repository at this point
Copy the full SHA 3588aa8View commit details -
Do not use static member (zimMajorVersion) in inlined constructor.
On Windows, static members are not exported in dll. So we must not use them in inlined method/constructor.
Configuration menu - View commit details
-
Copy full SHA for 6099dfa - Browse repository at this point
Copy the full SHA 6099dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b51eb32 - Browse repository at this point
Copy the full SHA b51eb32View commit details -
Do not unconditionally include search/xapian features
On Windows, if we declare a exported class, the implementation of this class is expected in the dll. When compiling without xapian we must not include headers for which we don't compile the implementation.
Configuration menu - View commit details
-
Copy full SHA for 34415e1 - Browse repository at this point
Copy the full SHA 34415e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98573d9 - Browse repository at this point
Copy the full SHA 98573d9View commit details -
MSVC throw a lot of warning because we also must re-export stl symbols used in our exported class. See [1] and [2] (and links inside) for more information. Especially [3] which seems to say that we should have issue at link time if it compatibility issue occurs (and so easily catchable). So I just remove the `werror=true` for now. [1] https://stackoverflow.com/questions/16419318/one-way-of-eliminating-c4251-warning-when-using-stl-classes-in-the-dll-interface [2] https://stackoverflow.com/questions/2132747/warning-c4251-when-building-a-dll-that-exports-a-class-containing-an-atlcstrin [3] https://stackoverflow.com/questions/2132747/warning-c4251-when-building-a-dll-that-exports-a-class-containing-an-atlcstrin#comment66255284_4563701
Configuration menu - View commit details
-
Copy full SHA for 0a1d2c3 - Browse repository at this point
Copy the full SHA 0a1d2c3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.