Introduce Archive::getMediaCount #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.91% // Head: 84.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
+ Coverage 84.91% 84.98% +0.06%
==========================================
Files 98 99 +1
Lines 4383 4428 +45
Branches 1894 1921 +27
==========================================
+ Hits 3722 3763 +41
- Misses 660 664 +4
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mgautierfr
force-pushed
the
get_media_count
branch
2 times, most recently
from
3fd15f6 to
cea515b
Compare
mgautierfr
force-pushed
the
get_media_count
branch
from
955bcb2 to
ee4c488
Compare
mgautierfr
force-pushed
the
get_media_count
branch
2 times, most recently
from
8920632 to
a119ec0
Compare
It corresponds to what is made on libkiwix.
mgautierfr
force-pushed
the
get_media_count
branch
from
a119ec0 to
7a40cce
Compare
|
@mgautierfr Good to merge? |
|
yes |
mgautierfr
added a commit
that referenced
this pull request
Nov 30, 2022
* Optimization ofthe first call to `zim::Archive::iterEfficient` (@veloman-yunkan #724) * Add some documentation to `zim::writer::IndexData` (@mgautierfr #727) * Correctly catch and rethrow exception thrown in worker threads at creation (@mgautierfr #496 #748) * Optimization of `Entry::getItem()` (@veloman-yunkan #732) * Fix declaration of `zim::setICUDataDirectory()` (@MohitMaliFtechiz #733) * Add `zim::Archive::getMediatCount()` (@mgautierfr #730) * Make compilaton of examples optional (@mgautierfr #738) * Add a CI for wasm (@mgautierfr #746) * Make constructor of SuggestionItem public (@veloman-yunkan #740)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #729
Code is based on getArchiveMediaCount in libkiwix.
readFullMimetypeAndCounterStringandparseASingleMimetypeCounterare copied from libkiwix, without modification.