Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh python bootstrap #51

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Refresh python bootstrap #51

merged 3 commits into from
Oct 2, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Oct 2, 2023

Rationale

Fix #49

Changes:

  • New html option in coverage report
  • Small fixes in invoke tasks
  • Dockerfile: split installation of Python dependencies for more efficiency
  • Github workflow: publish dev tag on every push to main branch
  • Github workflow: build Docker image + test its startup
  • Github workflow: adopt new standard execution structure (on conditions)

@benoit74 benoit74 requested a review from rgaudin October 2, 2023 07:59
@benoit74 benoit74 self-assigned this Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3c3aeb1) 24.90% compared to head (9cf26b9) 24.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   24.90%   24.90%           
=======================================
  Files           7        7           
  Lines         775      775           
  Branches      135      135           
=======================================
  Hits          193      193           
  Misses        570      570           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 2, 2023 08:01
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgaudin rgaudin merged commit 72493a8 into main Oct 2, 2023
7 checks passed
@benoit74 benoit74 deleted the refresh_python_bootstrap branch October 2, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to Python bootstrap modifications
2 participants