Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compute_descriptions from zimscraperlib to handle descriptions #125

Merged
merged 1 commit into from
May 6, 2024
Merged

Use compute_descriptions from zimscraperlib to handle descriptions #125

merged 1 commit into from
May 6, 2024

Conversation

githyuvi
Copy link
Contributor

@githyuvi githyuvi commented May 5, 2024 •
edited by kelson42
Loading

Fixes #50

Using the shared logic from python-scraper lib to compute descriptions and long descriptions

Tested on the following combinations

Description Long description
None None
<80c None
>80c None
<80c <4000
>80c <4000

@kelson42 kelson42 requested a review from benoit74 May 6, 2024 04:17
benoit74
benoit74 approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@benoit74 benoit74 merged commit 2d83b2b into openzim:new_ui May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit74 benoit74 benoit74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@githyuvi @benoit74