Skip to content

Conversation

Shreshth3
Copy link
Contributor

@Shreshth3 Shreshth3 commented Oct 11, 2025

Fixes #11040.

Right now, the -v and -o options for zpool list work independently, but when paired, the -v "wins out" and the -o effect is lost. This commit fixes that problem.

Before my change:
(master) ~/zfs$ ./zpool list -v -o name,health mypool
NAME          HEALTH
mypool        ONLINE
  mirror-0   960M   110K   960M        -         -     2%  0.01%      -    ONLINE
    loop17     1G      -      -        -         -      -      -      -    ONLINE
    loop18     1G      -      -        -         -      -      -      -    ONLINE
After my change:
(v-o-option-conflict) ~/zfs$ ./zpool list -v -o name,health mypool
NAME          HEALTH
mypool        ONLINE
  mirror-0    ONLINE
    loop17    ONLINE
    loop18    ONLINE

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Fixes openzfs#11040.

Right now, the -v and -o options for `zpool list`
work independently, but when paired, the -v
"wins out" and the -o effect is lost. This
commit fixes that problem.

Signed-off-by: Shreshth Srivastava <shreshthsrivastava2@gmail.com>
@github-actions github-actions bot added the Status: Work in Progress Not yet ready for general review label Oct 11, 2025
@Shreshth3 Shreshth3 marked this pull request as ready for review October 11, 2025 07:29
@github-actions github-actions bot added Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Code Review Needed Ready for review and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zpool list -v disregards other options

1 participant