ZVOL: Implement zvol_alloc() function on FreeBSD side #17482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement zvol_alloc() function on FreeBSD side to increase code base compatibility with Linux. Also, fix issue with late returning in case if volmmode='none'. Sponsored-by: vStack, Inc. Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com>
14 tasks
amotin
reviewed
Jun 24, 2025
| g_error_provider(zv->zv_zso->zso_geom.zsg_provider, 0); | ||
| /* geom was locked inside zvol_alloc() function */ | ||
| g_topology_unlock(); |
There was a problem hiding this comment.
Does not look great, but meh.
Worse here looks leak of the lock and everything else in case of dataset_kstats_create() error. Not your fault, but just spotted.
amotin
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Make FreeBSD/Linux code base more compatible.
Description
Implement zvol_alloc() function on FreeBSD side to increase code base compatibility with Linux.
Also, fix issue with late returning in case if volmmode='none'.
How Has This Been Tested?
Using ZFS testsuite.
Types of changes
Checklist:
Signed-off-by.