Validate mountpoint on path-based unmount using statx #17481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Use
statx
to verify that path-based unmounts proceed only if the mountpoint reported bystatx
matches theMNTTAB
entry reported bylibzfs
, aborting the operation if they differ. Alignzfs umount /path
behavior withzfs umount dataset
.Supersedes: #17421
Description
When zfs umount /path is run on a bind mount, it silently unmounts the underlying dataset. This patch uses
statx
to detect bind mounts accurately and validate the specified path against theMNTTAB
entry reported by libzfs before performing the unmount.How Has This Been Tested?
Before
After
Types of changes
Checklist:
Signed-off-by
.