Skip to content

Add explicit DMU_DIRECTIO checks #17342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2025
Merged

Add explicit DMU_DIRECTIO checks #17342

merged 1 commit into from
May 17, 2025

Conversation

amotin
Copy link
Member

@amotin amotin commented May 16, 2025

UIO_DIRECT means we can do Direct I/O, while DMU_DIRECTIO we want to do it. First does not automatically means second. Add few checks to not use Direct I/O in few cases we don't want it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Add explicit DMU_DIRECTIO checks
ee70a67 
UIO_DIRECT means we can do Direct I/O, while DMU_DIRECTIO we want
to do it.  First does not automatically means second.  Add few
checks to not use Direct I/O in few cases we don't want it.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@amotin amotin requested a review from bwatkinson May 16, 2025 16:50
@amotin amotin added the Status: Code Review Needed Ready for review and testing label May 16, 2025
@ixhamza ixhamza mentioned this pull request May 16, 2025
Merged
13 tasks
behlendorf
behlendorf approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, adding the DMU_DIRECTIO check here looks good. We want to do Direct IO, but don't have too.

@tonyhutter tonyhutter added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 16, 2025
@amotin amotin merged commit e55225b into openzfs:master May 17, 2025
23 of 24 checks passed
@amotin amotin deleted the direct2 branch May 17, 2025 03:27
ixhamza pushed a commit to truenas/zfs that referenced this pull request May 19, 2025
@amotin @ixhamza
Add explicit DMU_DIRECTIO checks
3505d45 
UIO_DIRECT means we can do Direct I/O, while DMU_DIRECTIO we want
to do it.  First does not automatically means second.  Add few
checks to not use Direct I/O in few cases we don't want it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#17342
@satmandu satmandu mentioned this pull request May 26, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

@bwatkinson bwatkinson Awaiting requested review from bwatkinson

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @behlendorf @tonyhutter