Skip to content

Export correct symbols for Lustre Direct I/O #17256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Export correct symbols for Lustre Direct I/O #17256

merged 1 commit into from
Apr 24, 2025

Conversation

bwatkinson
Copy link
Contributor

@bwatkinson bwatkinson commented Apr 18, 2025 •
edited
Loading

Originally the Lustre ZFS OSD code was going to use zfs_uio_t structs for supporting Direct I/O with ZFS. However, this has changed to using abd_t structs instead. This exports the proper symbols that will be used by the Lustre ZFS OSD code.

Updated exported symbols that will be used by Lustre.

Motivation and Context

These symbols need to be exported so support for ZFS Direct I/O can be added to the OSD ZFS code.

Description

Exported the following symbols:

  1. dmu_read_abd()
  2. dmu_write_abd()
  3. abd_alloc_from_pages()
  4. abd_free()
    These are needed as Lustre will be using abd_t's to issue Direct I/O.

I also stopped exporting the following symbols:

  1. dmu_read_uio_direct()
  2. dmu_write_uio_direct()
    These no longer needed to be exported.

How Has This Been Tested?

Built ZFS after updating the exports.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@bwatkinson bwatkinson requested a review from behlendorf April 18, 2025 20:29
amotin
amotin reviewed Apr 21, 2025
View reviewed changes
@bwatkinson
Export correct symbols for Lustre Direct I/O
76688e3 
Originally the Lustre ZFS OSD code was going to use zfs_uio_t structs
for supporting Direct I/O with ZFS. However, this has changed to using
abd_t structs instead. This exports the proper symbols that will be used
by the Lustre ZFS OSD code.

Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Apr 23, 2025
@tonyhutter tonyhutter added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 23, 2025
@amotin amotin merged commit 7031a48 into openzfs:master Apr 24, 2025
23 of 24 checks passed
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request May 2, 2025
@bwatkinson @snajpa
Export correct symbols for Lustre Direct I/O
6a2ba35 
Originally the Lustre ZFS OSD code was going to use zfs_uio_t structs
for supporting Direct I/O with ZFS. However, this has changed to using
abd_t structs instead. This exports the proper symbols that will be used
by the Lustre ZFS OSD code.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#17256
robn pushed a commit to robn/zfs that referenced this pull request May 23, 2025
@bwatkinson @robn
Export correct symbols for Lustre Direct I/O
e4853dc 
Originally the Lustre ZFS OSD code was going to use zfs_uio_t structs
for supporting Direct I/O with ZFS. However, this has changed to using
abd_t structs instead. This exports the proper symbols that will be used
by the Lustre ZFS OSD code.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#17256
(cherry picked from commit 7031a48)
@robn robn mentioned this pull request May 23, 2025
Closed
14 tasks
robn pushed a commit to robn/zfs that referenced this pull request May 24, 2025
@bwatkinson @robn
Export correct symbols for Lustre Direct I/O
df250c4 
Originally the Lustre ZFS OSD code was going to use zfs_uio_t structs
for supporting Direct I/O with ZFS. However, this has changed to using
abd_t structs instead. This exports the proper symbols that will be used
by the Lustre ZFS OSD code.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#17256
(cherry picked from commit 7031a48)
tonyhutter pushed a commit that referenced this pull request May 28, 2025
@bwatkinson @tonyhutter
Export correct symbols for Lustre Direct I/O
a77d641 
Originally the Lustre ZFS OSD code was going to use zfs_uio_t structs
for supporting Direct I/O with ZFS. However, this has changed to using
abd_t structs instead. This exports the proper symbols that will be used
by the Lustre ZFS OSD code.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes #17256
(cherry picked from commit 7031a48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

@behlendorf behlendorf Awaiting requested review from behlendorf

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwatkinson @amotin @tonyhutter