Skip to content

Linux 6.14 compat #17026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Linux 6.14 compat #17026

wants to merge 2 commits into from

Conversation

robn
Copy link
Member

@robn robn commented Feb 5, 2025

Motivation and Context

Everyday I talk to my machines
More sense than talking to human beings
It's pretty in the land of the free
Where things ain't quite what they seem

– Everyday Formula, Regurgitator, 1997.

It's your regularly-scheduled updates for Linux 6.14-rc1.

Description

See commit messages. Only two changes, both quite simple.

How Has This Been Tested?

Compiled and simple sanity check completed on 6.14-rc1 and 6.1.124. I'll do a full ZTS run on 6.14-rc1 in the next couple of days.

Note that there are still unconfirmed reports of flakiness on 6.12 and 6.13 (#16831). I can't see how this would make anything worse though.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

robn added 2 commits February 5, 2025 17:14
This is a convenience for filesystems that need the inode of their
parent or their own name, as its often complicated to get that
information. We don't need those things, so this is just detecting which
prototype is expected and adjusting our callback to match.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
According to the upstream change, all callers set it, and all block
devices either honoured it or ignored it, so removing it entirely allows
a bunch of handling for the "unset" case to be removed, and it becomes
effectively implied.

We follow suit, and keep setting it for older kernels.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Feb 5, 2025
@tonyhutter
Copy link
Contributor

Merged as 7ef6b70 2ca91ba

@tonyhutter tonyhutter closed this Feb 5, 2025
@robn
Copy link
Member Author

robn commented Feb 5, 2025

Bold move 😅 I'll report when the test suite run finishes anyway, still ticking but looking alright.

@robn robn mentioned this pull request Feb 6, 2025
13 tasks
@robn
Copy link
Member Author

robn commented Feb 6, 2025

Full ZTS run on 6.14-rc1 passed, so that's good enough for me for now.

I'm still a little concerned about the flaky test runs I had on 6.12 and 6.13, so I'll be trying to get more test runs against 6.12-6.14 kernels over the next days and weeks as my test rig has availability (a full run is up around ~12h for me these days, and I have my own changes to test too, so new kernels only get looked at when its idle). We shall see! And if anyone reading sees any problems, please report it in a new issue as normal. Thanks!

@robn
Copy link
Member Author

robn commented Feb 18, 2025

FYI tests passed on 6.14-rc3.

@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 20, 2025
ProxBot pushed a commit to proxmox/pve-kernel that referenced this pull request Mar 31, 2025
Provide a newer – currently – opt-in kernel that will form the base
for Ubuntu's 25.04 release.

Using the current relevant tag Ubuntu-6.14.0-12.12 (the newer 13.13
tag includes only some packaging changes that do not affect us) from
the upstream repo [0].

Update the patches, drop those that got applied upstream or are simply
not relevant for the newer kernel anymore. Update the ZFS submodule to
include a cherry-pick of the two Linux 6.14 compat patches that
already got applied to ZFS upstream [1].

[0]: https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/plucky/
[1]: openzfs/zfs#17026

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
@robn robn mentioned this pull request May 12, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants