Restore ASMABI and other Unify work #14569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundman
force-pushed
the
asmabi-pr
branch
2 times, most recently
from
094bcde to
7b9fb7b
Compare
Make sure all SHA2 transform function has wrappers For ASMABI to work, it is required the calling convention is consistent. Signed-off-by: Joergen Lundman <lundman@lundman.net>
mcmilk
approved these changes
Mar 4, 2023
Contributor
mcmilk
left a comment
mcmilk
left a comment
There was a problem hiding this comment.
Thank you for fixing these.
Contributor
|
The Fedora buildbot failure is #14584. |
ryao
approved these changes
Mar 6, 2023
Contributor
ryao
left a comment
ryao
left a comment
There was a problem hiding this comment.
We need documentation on what not to do when writing new assembly code for other contributors to read. Otherwise, this is going to keep regressing in PRs. We could simply tell people to fix their PRs to be consistent with the existing code, but that is not going to necessarily mean that they will know what to do.
mcmilk
pushed a commit
to mcmilk/zfs
that referenced
this pull request
Mar 13, 2023
Make sure all SHA2 transform function has wrappers For ASMABI to work, it is required the calling convention is consistent. Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Joergen Lundman <lundman@lundman.net> Closes openzfs#14569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all SHA2 transform function has wrappers
For ASMABI to work, it is required the calling convention is consistent.
Some were lost in #13741
Motivation and Context
ASMABI means we can share the same assembly file with Windows and macOS.
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.