Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process script directory for all configs #14051

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Process script directory for all configs #14051

merged 1 commit into from
Oct 27, 2022

Conversation

szubersk
Copy link
Contributor

Motivation and Context

Fix #14027.

Description

How Has This Been Tested?

$ make

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@szubersk szubersk changed the title Process script directory for all configs [WIP] Process script directory for all configs Oct 17, 2022
@szubersk szubersk marked this pull request as draft October 17, 2022 12:33
@behlendorf behlendorf added Component: Packaging custom packages Status: Code Review Needed Ready for review and testing labels Oct 21, 2022
@szubersk szubersk force-pushed the szubersk-build branch 2 times, most recently from 3aff6ff to 4168812 Compare October 23, 2022 00:29
@szubersk
Process script directory for all configs
a8bc6d3 
Fix openzfs#14027.

Signed-off-by: szubersk <szuberskidamian@gmail.com>
@szubersk szubersk changed the title [WIP] Process script directory for all configs Process script directory for all configs Oct 23, 2022
@szubersk szubersk marked this pull request as ready for review October 23, 2022 06:08
behlendorf
behlendorf approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've often wanted to do this myself. With the noinst change for the kernel-side build this seems like a pretty reasonable way to handle this.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 27, 2022
@szubersk
Copy link
Contributor Author

Thanks, Brian.

@behlendorf behlendorf merged commit 1428ede into openzfs:master Oct 27, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 28, 2022
@szubersk @andrewc12
Process script directory for all configs
380816e 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
shodanshok pushed a commit to shodanshok/zfs that referenced this pull request Oct 30, 2022
@szubersk @shodanshok
Process script directory for all configs
d0edd30 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
shodanshok pushed a commit to shodanshok/zfs that referenced this pull request Nov 3, 2022
@szubersk @shodanshok
Process script directory for all configs
e0f38a0 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
shodanshok pushed a commit to shodanshok/zfs that referenced this pull request Nov 3, 2022
@szubersk @shodanshok
Process script directory for all configs
e0efeef 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
@szubersk szubersk deleted the szubersk-build branch November 4, 2022 10:12
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
9f76ad4 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
2d0d4c8 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
3578599 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
1315e52 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
437beb4 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
f75b1ee 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
5685827 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 10, 2022
@szubersk @andrewc12
Process script directory for all configs
932f7cd 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 10, 2022
@szubersk @andrewc12
Process script directory for all configs
ec8bcda 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#14027
Closes openzfs#14051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--with-config=kernel does not generate common.sh for zfs.sh
2 participants
@szubersk @behlendorf