Skip to content

Conversation

@mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Jul 31, 2022

This commit fixes these current checkstyle warnings/errors in CI:

./contrib/pyzfs/libzfs_core/_constants.py:109:7: E275 missing whitespace after keyword
./contrib/pyzfs/build/lib/libzfs_core/_constants.py:109:7: E275 missing whitespace after keyword
make: *** [Makefile:13787: flake8] Error 1
make: *** Waiting for unfinished jobs....
Error: Process completed with exit code 2.

Signed-off-by: Tino Reichardt milky-zfs@mcmilk.de

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
@mcmilk mcmilk force-pushed the fix-checkstyle-e275-warning branch from 74b0832 to 7ebfce1 Compare July 31, 2022 16:15
@mcmilk mcmilk changed the title Fix 2x checkstyle warning: E275 missing whitespace after keyword Fix checkstyle warning: E275 missing whitespace after keyword Jul 31, 2022
@gmelikov
Copy link
Member

Could you please point at error in CI (exact test run)? I wonder why I didn't saw it as run error before.

@mcmilk
Copy link
Contributor Author

mcmilk commented Jul 31, 2022

Could you please point at error in CI (exact test run)? I wonder why I didn't saw it as run error before.

I just noticed it while working on the sha2 stuff... and then I rebased my Edon-R PR (#13618) ... here is the checkstyle output of it: https://github.com/openzfs/zfs/runs/7599630517?check_suite_focus=true

Edit: I think the CI got some update...

Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, if may be flake8 update. PR itself is LGTM, thank you!

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Aug 1, 2022
@behlendorf behlendorf merged commit 51946ed into openzfs:master Aug 1, 2022
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 2, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
behlendorf pushed a commit that referenced this pull request Aug 2, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes #13710
@mcmilk mcmilk deleted the fix-checkstyle-e275-warning branch August 3, 2022 07:56
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Aug 26, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Aug 26, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Aug 31, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 2, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 2, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
hpingfs pushed a commit to iomesh/zfs that referenced this pull request Sep 21, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
hpingfs pushed a commit to iomesh/zfs that referenced this pull request Sep 21, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
kylezh pushed a commit to iomesh/zfs that referenced this pull request Sep 22, 2022
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
andrewc12 added a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
…s#128)

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#13710

Co-authored-by: Tino Reichardt <milky-zfs@mcmilk.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants