check_prop_source: improve output clarity #11517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an identical definition in zfs_set_common.kshlib already. Signed-off-by: Will Andrews <will@firepipe.net>
Instead of just failing, indicate the expected and actual value and source as a NOTE. Tests using this failed in an earlier version of the changeset and this information helped find the cause. Signed-off-by: Will Andrews <will@firepipe.net>
12 tasks
behlendorf
approved these changes
Jan 25, 2021
ghost
approved these changes
Jan 25, 2021
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Instead of just failing, indicate the expected and actual value and source as a NOTE. Tests using this failed in an earlier version of the changeset and this information helped find the cause. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Will Andrews <will@firepipe.net> Closes openzfs#11517
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Instead of just failing, indicate the expected and actual value and source as a NOTE. Tests using this failed in an earlier version of the changeset and this information helped find the cause. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Will Andrews <will@firepipe.net> Closes openzfs#11517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When tests using
check_prop_sourcefail, it's helpful to see the original data that shows why it failed.Description
Log a note explaining what was expected and what was observed, when checking property value and source.
How Has This Been Tested?
ZTS
Types of changes
Checklist:
Signed-off-by.