Warnings on compiling on Debian 11 AArch64

[rincebrain]

System information

Type	Version/Name
Distribution Name	Debian
Distribution Version	11.4
Kernel Version	5.10.0-16-arm64
Architecture	AArch64
OpenZFS Version	947465b

Describe the problem you're observing

Given the interest in being -Werror-clean, I thought this was worth reporting after seeing it while testing #13741:

lib/libzfs/libzfs_dataset.c: In function ‘zfs_rename’:
lib/libzfs/libzfs_dataset.c:4416:1: note: parameter passing for argument of type ‘renameflags_t’ {aka ‘struct renameflags’} changed in GCC 9.1
 4416 | zfs_rename(zfs_handle_t *zhp, const char *target, renameflags_t flags)
      | ^~~~~~~~~~
  CC       lib/libzfs/os/linux/libzfs_la-libzfs_mount_os.lo
  CC       lib/libzfs/os/linux/libzfs_la-libzfs_pool_os.lo
lib/libzfs/libzfs_pool.c: In function ‘zpool_valid_proplist’:
lib/libzfs/libzfs_pool.c:453:1: note: parameter passing for argument of type ‘prop_flags_t’ {aka ‘struct prop_flags’} changed in GCC 9.1
  453 | zpool_valid_proplist(libzfs_handle_t *hdl, const char *poolname,
      | ^~~~~~~~~~~~~~~~~~~~
lib/libzfs/libzfs_dataset.c: In function ‘zfs_rename’:
lib/libzfs/libzfs_dataset.c:4416:1: note: parameter passing for argument of type ‘renameflags_t’ {aka ‘struct renameflags’} changed in GCC 9.1
 4416 | zfs_rename(zfs_handle_t *zhp, const char *target, renameflags_t flags)
      | ^~~~~~~~~~
  CC       lib/libzfs/os/linux/libzfs_la-libzfs_util_os.lo
  CC       lib/libshare/libshare_la-libshare.lo
lib/libzfs/libzfs_pool.c: In function ‘zpool_valid_proplist’:
lib/libzfs/libzfs_pool.c:453:1: note: parameter passing for argument of type ‘prop_flags_t’ {aka ‘struct prop_flags’} changed in GCC 9.1
  453 | zpool_valid_proplist(libzfs_handle_t *hdl, const char *poolname,
      | ^~~~~~~~~~~~~~~~~~~~

$ gcc --version
gcc (Debian 10.2.1-6) 10.2.1 20210110

Describe how to reproduce the problem

Build without --enable-debug. (I presume --enable-debug will also do this, but that's not what I was doing.)

Include any warning/errors/backtraces from the system logs

Above.

[szubersk]

GCC changed how struct is passed to functions by value, breaking ABI. API functions compiled with the pre-change toolchain cannot be appropriately consumed by code compiled with the post-change toolchain. Internally, it doesn't matter to OpenZFS since the whole project is compiled with the same toolchain. lib* consumers are going to get a warning from the compiler they use.

Two possible solutions:

• -Wno-psabi in automake rules
• whitelist those 2 "problematic" functions by #pragma

zfs_rename is public, refactoring it to accept struct * might break compatibility.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77728

[stale]

This issue has been automatically marked as "stale" because it has not had any activity for a while. It will be closed in 90 days if no further activity occurs. Thank you for your contributions.