This repository was archived by the owner on Feb 26, 2020. It is now read-only.
Vnode improvements #493
Closed
Vnode improvements #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lock is only used on creation and does not mutually exclude anything. It is unnecessary overhead. Signed-off-by: Richard Yao <ryao@gentoo.org>
There is no need to use atomic operations on ->f_ref when it is protected by a spinlock. Signed-off-by: Richard Yao <ryao@gentoo.org>
|
Since this is just cleanup which shouldn't have any real impact on performance and this is all code I'd like to return (see #497) I'd prefer not to merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vnode code has redundant mutexes and atomics.